Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tabs as a child page #5334

Closed
jpmckearin opened this issue Feb 4, 2016 · 8 comments
Closed

feat: Tabs as a child page #5334

jpmckearin opened this issue Feb 4, 2016 · 8 comments
Assignees
Milestone

Comments

@jpmckearin
Copy link

Type: feat

Ionic Version: 2.x

Platform: mobile webview

Use case: Master-detail pages where the master is a list of items and the details view is broken into different tabs. Currently, a tabs page has it's own nav stack for each individual tab using the [root] property. This would allow navigation into and out of a tabs detail page back to a master page. This was discussed during development of Ionic 1 but was decided to be put off for Ionic 2 due to limitations with ui-router.

@jpmckearin jpmckearin changed the title feat: feat: Navigate in and out of tabs from a parent pa feat: Navigate in and out of tabs from a parent pa Feb 4, 2016
@jpmckearin jpmckearin changed the title feat: Navigate in and out of tabs from a parent pa feat: Tabs as a child page Feb 4, 2016
@adamdbradley
Copy link
Contributor

Have you tried this with Ionic2? This should be able to work or I may be reading it wrong. An ion-tabs is no different than an ion-page as far as ion-nav is concerned, and you push and pop different ion-tabs onto the stack.

@jpmckearin
Copy link
Author

@adamdbradley is there an Ionic 2 codepen starter somewhere that you know of? I'll throw one together if not

DISREGARD: I'll throw together a github repo later

@jgw96
Copy link
Contributor

jgw96 commented Feb 5, 2016

This should be possible if im understanding whats being asked correctly. @jpmckearin would a codepen starter be easier for you? I can throw that together if needed.

@jpmckearin
Copy link
Author

@jgw96 I think a couple of codepen starters, like we have for ionic v1, would make it much easier to communicate issues in the future. I'm just strapped for time at the moment

@lordgreg
Copy link

lordgreg commented Feb 5, 2016

This is exactly the same issue as I've already said:

@jgw96
Copy link
Contributor

jgw96 commented Feb 18, 2016

@lordgreg @jpmckearin you are able to simply push() a tabs "page" in Ionic 2 with the new navigation. Check out my repo GitNinja for an example of how to go from a simple page to a tabs page in Ionic 2.

@lordgreg
Copy link

@jgw96 I've just checked your repo and haven't found any tabs implemented at all. However, you're missing the point here; There's no problem pushing Tab page to navigation stack. It is bugged because of current Angular2 Routing service implementation.

This is the exact same issue I've posted here. Check the project I've made inside the link, and you will see where the problem is.

@brandyscarney brandyscarney added this to the 2.0.0-beta.6 milestone Mar 1, 2016
@adamdbradley
Copy link
Contributor

Looks like this may have already been solved. If you're still having any issues please feel free create a new issue with a few examples, thanks.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants