Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron to platform registry #6274

Closed
adamdbradley opened this issue Apr 22, 2016 · 3 comments
Closed

Add Electron to platform registry #6274

adamdbradley opened this issue Apr 22, 2016 · 3 comments

Comments

@adamdbradley
Copy link
Contributor

adamdbradley commented Apr 22, 2016

Just like Cordova, Electron is another platform engine which Ionic can support. Add Electron to the platform registry, and add the appropriate events custom to Electron, but emitting the standardized Platform events. Start by copying the cordova platform registry.

https://github.com/driftyco/ionic/blob/95ee2bb448e9c91d6657ade393f2d615c377c8d8/ionic/platform/registry.ts#L165

@adamdbradley adamdbradley added v2 help wanted a good issue for the community and removed help wanted a good issue for the community labels Apr 22, 2016
@jgw96
Copy link
Contributor

jgw96 commented Apr 26, 2016

Here's what i have so far on this. Figured out from the limited info on the web, and through testing that the best way to check if your running on electron is to check the UA for "electron". The UA always has electron in it, even on windows. So using this i now have the electron platform triggering perfectly. Looking at events now and heres what i have on that so far. It looks like in the renderer process (electron apps have two main "processes"), which is where ionic is running its just standard browser events (like window.onload etc etc) and no custom events specific to electron.

@NorthMcCormick
Copy link

Understand this is closed, but I am looking at being able to trigger the platform ready for some electron stuff I'm working on. Would it be okay if I did a PR that registers electron or is this coming up in the next release (I'm definitely looking at having it sooner than later :P)

Just let me know :)

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot unassigned jgw96 Sep 3, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants