Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized Gesture Controller #6726

Closed
adamdbradley opened this issue Jun 1, 2016 · 1 comment
Closed

Centralized Gesture Controller #6726

adamdbradley opened this issue Jun 1, 2016 · 1 comment
Assignees

Comments

@adamdbradley
Copy link
Contributor

adamdbradley commented Jun 1, 2016

Right now each component that have gestures can work stand-alone, which is fine. However, sometimes multiple components with gestures are all valid to work, but all act at the same time. For example, imagine a range inside of a sliding item inside of slides on a swipe to go back page that can scroll and has a left menu. Who should work when you swipe left?? The goal is to not reimplement Hammer gestures, but rather centralize which "one" gesture component should be listening on the move events.

Create a GestureController class and add it to our providers in ionicBootstrap. Then each component that has gestures, like range/menu/itemSliding/slides/etc, all would inject the GestureController instance. For each individual component, they would first ask the GestureController if it's ok if their gestures should work or not, and also have the ability to cancel all other already active gestures.

@jgw96
Copy link
Contributor

jgw96 commented Jun 20, 2016

Im pretty sure this is related: #6897. If we could configure the hammer events to work vertically too like @danbucholtz mentioned this morning it should fix this issue.

This was referenced Jun 27, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants