Skip to content

Conversation

@rugoncalves
Copy link

Issue number: resolves #


What is the current behavior?

The current version in use of stencil (4.36.2), as well as, a more recent version (4.38.0) are breaking the tests for several of the components (e.g. accordion, datepicker, modal)

What is the new behavior?

  • Reverting the version of stencil to the last known stable version 4.33.1

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@rugoncalves rugoncalves requested a review from a team as a code owner October 6, 2025 10:31
@vercel
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 6, 2025 10:31am

@github-actions github-actions bot added the package: core @ionic/core package label Oct 6, 2025
@rugoncalves rugoncalves changed the title fix(stencil-version): Revert stencil to version 4.33.1 fix(stencil-version): revert stencil to version 4.33.1 Oct 6, 2025
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally against this, but I'm approving because I understand it's a temporary requirement to bypass an issue until more time can be spent investigating the cause of your issues later.

@brandyscarney brandyscarney changed the title fix(stencil-version): revert stencil to version 4.33.1 chore(deps): revert stencil to version 4.33.1 Oct 7, 2025
@rugoncalves rugoncalves merged commit 9a1d3ca into next Oct 7, 2025
146 of 151 checks passed
@rugoncalves rugoncalves deleted the ROU-11881-revert-stencil-version branch October 7, 2025 15:47
OS-giulianasilva added a commit that referenced this pull request Oct 28, 2025
Issue number: resolves internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
- The Stencil version was previously reverted under #30707 because of
test failures of components form another repo.

## What is the new behavior?
- Update the version again to match what we have in main, since these
tests were fixed.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants