Skip to content

Commit 4092831

Browse files
committed
fix(http): add correct return types for downloadFile and uploadFile
closes: #2615
1 parent c2fe5f8 commit 4092831

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/@ionic-native/plugins/http/index.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export class HTTP extends IonicNativePlugin {
7474
* This returns an object representing a basic HTTP Authorization header of the form.
7575
* @param username {string} Username
7676
* @param password {string} Password
77-
* @returns {Object} an object representing a basic HTTP Authorization header of the form {'Authorization': 'Basic base64encodedusernameandpassword'}
77+
* @returns {Object} an object representing a basic HTTP Authorization header of the form {'Authorization': 'Basic base64EncodedUsernameAndPassword'}
7878
*/
7979
@Cordova({ sync: true })
8080
getBasicAuthHeader(
@@ -283,7 +283,7 @@ export class HTTP extends IonicNativePlugin {
283283
* @param headers {Object} The headers to set for this request
284284
* @param filePath {string} The local path of the file to upload
285285
* @param name {string} The name of the parameter to pass the file along as
286-
* @returns {Promise<HTTPResponse>} returns a promise that resolve on success, and reject on failure
286+
* @returns {Promise<FileEntry>} returns a promise that resolve on success, and reject on failure
287287
*/
288288
@Cordova()
289289
uploadFile(
@@ -292,7 +292,7 @@ export class HTTP extends IonicNativePlugin {
292292
headers: any,
293293
filePath: string,
294294
name: string
295-
): Promise<HTTPResponse> {
295+
): Promise<FileEntry> {
296296
return;
297297
}
298298

@@ -301,16 +301,16 @@ export class HTTP extends IonicNativePlugin {
301301
* @param url {string} The url to send the request to
302302
* @param body {Object} The body of the request
303303
* @param headers {Object} The headers to set for this request
304-
* @param filePath {string} The path to donwload the file to, including the file name.
305-
* @returns {Promise<HTTPResponse>} returns a promise that resolve on success, and reject on failure
304+
* @param filePath {string} The path to download the file to, including the file name.
305+
* @returns {Promise<FileEntry>} returns a promise that resolve on success, and reject on failure
306306
*/
307307
@Cordova()
308308
downloadFile(
309309
url: string,
310310
body: any,
311311
headers: any,
312312
filePath: string
313-
): Promise<HTTPResponse> {
313+
): Promise<FileEntry> {
314314
return;
315315
}
316316
}

0 commit comments

Comments
 (0)