-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SocialSharing: Add missing methods (setIPadPopupCoordinates) #1288
Labels
Comments
Hey @FdezRomero, I added the method. Wait for the next release. |
Great! Thanks @danielsogl 👍 I was going to submit a PR but I don't fully understand (yet) the inner workings of the changes made in 3.x. |
ihadeed
pushed a commit
that referenced
this issue
May 9, 2017
* refactor(social sharing): added missing method fix #1288 * Update index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there!
I noticed there are some missing methods in the SocialSharing plugin, especially
setIPadPopupCoordinates
, which is needed to specify the position and size of the button the user has pressed so that the sharing popup on iPad can be positioned according to Apple's guidelines. And as you all know, not doing this may be a reason for app rejection.Would also be a good opportunity to review and add all the other missing methods. You can check them here: https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/blob/master/www/SocialSharing.js
Thanks!
The text was updated successfully, but these errors were encountered: