-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppPreferences] store should accept string, number, boolean #1334
Comments
Hey @EbilPanda, I implemented your suggestions. |
ihadeed
pushed a commit
that referenced
this issue
May 9, 2017
* refactor(AppPreferences): changed input type fix #1334 * Update index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
as stated in the title - AppPreference-Plugin accepts
string, number, boolean
as inputs, as stated herecurrently it only accepts string as keys and value, so if I define an value (e.q. boolean -> toogle-type in app-settings.json) and want to change it in code, the saved type will be changed to string and the preference-screen will not work anymore because the type is not as expected
solution:
change
to
(key must be same because of overloading...)
The text was updated successfully, but these errors were encountered: