feat(user-agent): add User-Agent plugin #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
requested changes
May 19, 2017
| import {Plugin, Cordova, IonicNativePlugin} from '@ionic-native/core'; | ||
|
|
||
| /** | ||
| * @name User-Agent |
There was a problem hiding this comment.
This should be User Agent without the dash in between. Was this automatically generated by the gulp plugin:create command?
ihadeed
requested changes
May 19, 2017
| @@ -0,0 +1,73 @@ | |||
| import {Injectable} from '@angular/core'; | |||
| import {Plugin, Cordova, IonicNativePlugin} from '@ionic-native/core'; | |||
There was a problem hiding this comment.
Please add spaces between the import names and the brackets. A space after { and a space before }.
|
Why did the build fail if all I did was add whitespaces? It's building correctly on my side. |
|
@helderdiniz there wasn't an issue with your code, it was just mistake with the latest CI tests script I published. Everything is fine. Thanks for the PR :) |
|
Glad to know then! Hope to see this soon, cheers and thanks for the good work on the framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plugin that might be interesting for the framework, the cordova-useragent. It's based on https://github.com/LouisT/cordova-useragent