-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLite sqlBatch
type checking is wrong
#1596
Labels
Comments
ihadeed
added a commit
that referenced
this issue
Jul 10, 2017
BuddyLReno
pushed a commit
to BuddyLReno/ionic-native
that referenced
this issue
Aug 28, 2017
Does this fix included in 3.12.1 version? |
This was closed in version 4.0.0 according to the Changelog. (technically it was a lazy fix because it was just made into an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
Currently this is what the type-checking checks for:
Expected behavior:
However, this is what it should be:
Steps to reproduce:
You can check the official plugin repo source/test script here to verify what I said was correct: https://github.com/litehelpers/Cordova-sqlite-storage/blob/storage-master/spec/www/spec/sql-batch-test.js
i.e.:
Other information:
package.json info:
The text was updated successfully, but these errors were encountered: