Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getPermissionSubscriptionState #1678

Merged
merged 2 commits into from
Jun 11, 2017
Merged

Add getPermissionSubscriptionState #1678

merged 2 commits into from
Jun 11, 2017

Conversation

neoassyrian
Copy link
Contributor

Adde d a new method available in the oneSignal Cordova SDK
https://documentation.onesignal.com/docs/cordova-sdk

More methods will probably need to be added

Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the lint issues (trailing whitespaces)

(no-trailing-whitespace) @ionic-native/plugins/onesignal/index.ts[229, 24]: trailing whitespace
(no-trailing-whitespace) @ionic-native/plugins/onesignal/index.ts[239, 25]: trailing whitespace
(no-trailing-whitespace) @ionic-native/plugins/onesignal/index.ts[242, 1]: trailing whitespace
(no-trailing-whitespace) @ionic-native/plugins/onesignal/index.ts[244, 1]: trailing whitespace

@neoassyrian
Copy link
Contributor Author

Updated

@danielsogl
Copy link
Owner

danielsogl commented Jun 10, 2017

@neoassyrian There are still CI errors (build).
Have you run the commands npm run lint and npm run build to test the changes locally?

@ihadeed ihadeed merged commit e9283a9 into danielsogl:master Jun 11, 2017
@neoassyrian
Copy link
Contributor Author

I'm a bit new to this. How can I update the files locally on my dev?
I tried to update the index.d.ts file installed in my "node_modules" and re-built the project (ionic cordova build) and had no errors.

Any how to?

@ihadeed
Copy link
Collaborator

ihadeed commented Jun 12, 2017

@neoassyrian what do you mean by "update the files locally"? what are you trying to update?

@neoassyrian
Copy link
Contributor Author

I meant when I add the onesignal module in my project and then try to modify the files locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants