Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [google-maps]: HtmlInfoWindow missing .on and .one methods #2034 #2035

Merged
merged 90 commits into from
Nov 1, 2017
Merged

Fix: [google-maps]: HtmlInfoWindow missing .on and .one methods #2034 #2035

merged 90 commits into from
Nov 1, 2017

Conversation

wf9a5m75
Copy link
Contributor

@wf9a5m75 wf9a5m75 commented Oct 9, 2017

HtmlInfoWindow class should extend BaseClass.

wf9a5m75 and others added 30 commits July 17, 2017 10:05
@wf9a5m75
Update index.ts
c7d1f23
@wf9a5m75
Update index.ts
f20d61a
Add missing features, and bug fix of methods
17a06ec
update: classname must be in pascal case
7dabc77
remove: duplicated class definition
9897a1e
export encode and spherical static classes
c476025
Add comma
dde96b1
@ihadeed
Fix Encoding and Spherical
ccee755
@ihadeed
Add convenience methods
46127c0
@ihadeed
Fix decorators for Encoding and Spherical
9216c00
@wf9a5m75
Update: getMap() methods return the instance of the wrapper plugin
1720dcc
@wf9a5m75
Update: getMap() methods return the instance of the wrapper plugin
980f35d
@wf9a5m75
Remove @CordovaInstance decorators from getMap()
4b29aec
@wf9a5m75
Update: GoogleMapOptions (all fields are not optional).
dd77ec4
@wf9a5m75
Follow up: version 2.0.0-beta2-20170719-2226 of cordova-plugin-goog…
93311ea 
…lemaps
@wf9a5m75
Fix: tslint error
2337316
@wf9a5m75
Fix: tslint error
73a670b
No more isAvailable() method.
e679868
Merge remote-tracking branch 'upstream/master'
06fb7d2
Bug fix: description is incorrect
84500a8
Bug fix: example code was wrong.
18843c1
@wf9a5m75
Bug fix: HtmlInfoWindow does not work
da75beb 
#1815 (comment)
@wf9a5m75
Bug fix: HtmlInfoWindow does not work
3e8a58c
@wf9a5m75
Bug fix: HtmlInfoWindow does not work
732ac65
@wf9a5m75
Bug fix: HtmlInfoWindow does not work
b4d8da9
@wf9a5m75
Bug fix: HtmlInfoWindow does not work
30a674f
It seems the ionViewDidLoad() is enough delayed after platform.ready()
7d22ecc
Bug fix: map.setDiv()
81c2a92
Bug fix: HtmlInfoWindow does not work
57179a1
Bug fix: BaseArrayClass definition is incorrect
2c7e686
@wf9a5m75
Update index.ts
c2e3084
@wf9a5m75
fix: need to convert instance type from the JS class to the wrapper c…
b359caa 
…lass

mapsplugin/cordova-plugin-googlemaps#1706
@wf9a5m75
Merge commit '07835207231d485d54579ea9b17586fdd1fc3cbf'
32e91c2
@wf9a5m75
remove test file
266ac95
@wf9a5m75
fix: Error: Illegal use of "@Private" tag.
75e97e4
@wf9a5m75
fix: The Environment, Encode, and Spherical are static class
cc05636
@wf9a5m75
fix: convert JS instance to the ionic instance
bae4cb6 
add: BaseClass.destroy()
add: getId() method for all instance classes
@wf9a5m75
Merge commit '536a90636663a5cc536a0078ed86ad4e5e9bdbb0'
980ecf0
@wf9a5m75
Documentation Error #1994
a47fc45
@wf9a5m75
Need to create another way to convert the instance for marker cluster
2f779aa
@wf9a5m75
save
1eb2153
@wf9a5m75
Remove the instance of wrapper class if the JS instance is removed.
733dd4b
@wf9a5m75
Bug fix: HtmlInfoWindow missing .on and .one methods
ef5b829 
#2034
@wf9a5m75
Merge commit 'ef28078815536b1bd1a9c4efbcea815656b943e6'
2f61306
@wf9a5m75 wf9a5m75 mentioned this pull request Oct 9, 2017
Closed
@wf9a5m75 wf9a5m75 mentioned this pull request Oct 13, 2017
Closed
@wf9a5m75 wf9a5m75 mentioned this pull request Oct 26, 2017
Closed
lecajer
lecajer reviewed Oct 27, 2017
View reviewed changes
Copy link

@lecajer lecajer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 we need this fix "Error when removing map"
Any idea how to get this merged in the official version of ionic-native ?

@wf9a5m75
Copy link
Contributor Author

@jeremlicious Try from my repository.

$> git clone https://github.com/wf9a5m75/ionic-native

$> cd ionic-native

$> node -v
7.10

$> npm run build google-maps

$> cd (your project folder)

$> npm uninstall @ionin-native/core @ionic-native/google-maps

$> npm install (path to)/ionic-native/dist/\@ionic-native/core

$> npm install (path to)/ionic-native/dist/\@ionic-native/google-maps

@wf9a5m75
Add: the cssOptions argument for HtmlInfoWindow.setContent() method
a8d484d
@wf9a5m75
Bug fix: Polyline.getPoints(), Polygon.getPoints() and Polygon.getHol…
f1b1614 
…es()

Those methods need to create new instance of BaseArrayClass of wrapper plugin.
@wf9a5m75
Add: forEachAsync(), mapAsync(), and filterAsync() methods into BaseA…
d9adf8d 
…rray class
@wf9a5m75
update: use document.querySelector() instead of document.getElementBy…
7dc3173 
…Id() if the passed element is string

update: map.setDiv()

Bug fix: can not create empty GoogleMap (pure JS version is available way)
@wf9a5m75
Fix: wait until the page is fully ready
10454c1
@wf9a5m75 wf9a5m75 mentioned this pull request Nov 1, 2017
Closed
@ihadeed ihadeed merged commit ce6e412 into danielsogl:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecajer lecajer lecajer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wf9a5m75 @lecajer @ihadeed