Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offsetTopBar in AdMob Pro #2100

Closed
wbhob opened this issue Nov 8, 2017 · 1 comment
Closed

offsetTopBar in AdMob Pro #2100

wbhob opened this issue Nov 8, 2017 · 1 comment

Comments

@wbhob
Copy link

wbhob commented Nov 8, 2017

I'm submitting a ... (check one with "x")
[ ] bug report
[x] feature request

Current behavior:

Right now, TypeScript complains when createBanner is called with the option offsetTopBar, but that is an option included with the plugin.

Expected behavior:

No errors, and the ads on top should drop below the status bar/notch (iPhone X)

Steps to reproduce:

Call AdMob.createBanner({offsetTopBar: true}) and watch nothing happen 😄
Related code:

insert any relevant code here

Other information:

package.json info:

        "@ionic-native/admob-pro": "^4.3.3",
cli packages: (/usr/local/lib/node_modules)

    @ionic/cli-utils  : 1.17.0
    ionic (Ionic CLI) : 3.17.0

global packages:

    cordova (Cordova CLI) : 7.0.1

local packages:

    @ionic/app-scripts : 3.0.1
    Cordova Platforms  : android 6.2.3 ios 4.5.3
    Ionic Framework    : ionic-angular 3.8.0

System:

    ios-deploy : 1.9.2
    ios-sim    : 6.1.2
    Node       : v8.2.1
    npm        : 5.5.1
    OS         : macOS High Sierra
    Xcode      : Xcode 9.1 Build version 9B55

Environment Variables:

    ANDROID_HOME : /usr/local/opt/android-sdk

Misc:

    backend : pro
@wbhob
Copy link
Author

wbhob commented Feb 6, 2018

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant