-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro: Reversed return types for "check" and "extract" #2127
Comments
The error assigned to it is |
Everyone looking for a solutoin / manual fix, see #2136 (comment) |
Can we have a fix for this? Seems like Ionic (again) is advertising a half baked/unfinished/buggy product called Ionic Pro 🙄 Thanks a lot @DavidTalamona for the fix though! |
Hi all, can you try version 4.5.3 of @ionic-native/pro? Both of these issues should be resolved. |
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://ionicworldwide.herokuapp.com/
Current behavior:
pro.deploy.check
returns Observable instead of Promise.pro.deploy.extract
causes "pluginObj.constructor.getPluginName is not a function" error because it's not an Observable, as it should be.Expected behavior:
Returned values should be as documented.
Steps to reproduce:
Just implement the live update process with the native plugin wrapper.
Related code: (https://github.com/ionic-team/ionic-native/blob/master/src/%40ionic-native/plugins/pro/index.ts)
should be:
Note the
{observable: true}
that I moved fromcheck
toextract
!The text was updated successfully, but these errors were encountered: