Add new Firebase phone verification methods #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
approved these changes
Dec 1, 2017
| @@ -30,89 +30,108 @@ import { Observable } from 'rxjs/Observable'; | |||
| plugin: 'cordova-plugin-firebase', | |||
| pluginRef: 'FirebasePlugin', | |||
| repo: 'https://github.com/arnesson/cordova-plugin-firebase', | |||
| platforms: ['Android', 'iOS'] | |||
| platforms: ['Android', 'iOS'], | |||
|
|
||
| /** | ||
| * Get notified when a token is refreshed | ||
| * @return {Observable<any>} | ||
| */ | ||
| @Cordova({ | ||
| observable: true | ||
| observable: true, |
|
|
||
| /** | ||
| * Get notified when the user opens a notification | ||
| * @return {Observable<any>} | ||
| */ | ||
| @Cordova({ | ||
| observable: true | ||
| observable: true, |
There was a problem hiding this comment.
My apologies, TSLint has a config option on by default that adds a trailing comma, so when you need to extend an object or array, you can just start typing. I've grown used to it because I'm lazy :)
|
|
||
| /** | ||
| * Grant permission to receive push notifications | ||
| * @return {Promise<any>} | ||
| */ | ||
| @Cordova({ | ||
| platforms: ['iOS'] | ||
| platforms: ['iOS'], |
|
Also, there has been a bit of code rot in the underlying cordova plugin, I'm working with the repo owner to try to get him to re-publish to npm. He forgot to bump the package version when merging the PR this PR is related to, so the package on npm is out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.