feat(calldirectory): add call directory plugin #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsogl
requested changes
Apr 23, 2018
| repo: 'https://github.com/GEDYSIntraWare/cordova-plugin-call-directory', | ||
| install: 'cordova plugin add cordova-plugin-call-directory --variable EXT_NAME="Cordova-Directory" --variable ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES="NO"', | ||
| installVariables: ['EXT_NAME', 'ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES'], | ||
| }) |
There was a problem hiding this comment.
add supported platforms (e.g platforms: ['Android', 'iOS'])
|
|
||
| /** | ||
| * Add identification numbers | ||
| * @param items {Array<CallDirectoryItem>} Set of numbers with labels |
There was a problem hiding this comment.
Change JSDOC to @param {type} param description
|
|
||
| /** | ||
| * Remove identification numbers | ||
| * @param items {Array<CallDirectoryItem>} Set of numbers with arbitrary label |
There was a problem hiding this comment.
Change JSDOC to @param {type} param description
|
Thanks for your feedback. I have corrected those problems. Is adding a separate commit correct or should I squash my changes to one commit? |
|
I will do the squash merge 😄 You can spam as many commits as you want 😀 |
danielsogl
approved these changes
Apr 23, 2018
|
I see 😃 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the plugin for identfifying incomming calls: https://www.npmjs.com/package/cordova-plugin-call-directory