Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP plugin wrapper not returning FileEntry as Promise type for upload and download file functions #2615

Closed
gmaye opened this issue Jul 28, 2018 · 0 comments
Closed

HTTP plugin wrapper not returning FileEntry as Promise type for upload and download file functions #2615

gmaye opened this issue Jul 28, 2018 · 0 comments
Assignees
@danielsogl
Labels
bug improve docs improve plugin

Comments

@gmaye
Copy link

gmaye commented Jul 28, 2018 •
edited
Loading

https://github.com/ionic-team/ionic-native/blob/c2fe5f83366a17738d6f6713eee19729f2660001/src/%40ionic-native/plugins/http/index.ts#L313

I was checking out https://github.com/silkimen/cordova-plugin-advanced-http plugin and noticed that both the uploadFile and downloadFile functions return a FileEntry object in the success callback. Ionic's wrapper sets their response type as Promise<HTTPResponse> instead of Promise<FileEntry>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielsogl danielsogl

Labels
bug improve docs improve plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmaye @danielsogl