Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lastCam): add plugin #2759

Merged
merged 4 commits into from
Oct 17, 2018
Merged

feat(lastCam): add plugin #2759

merged 4 commits into from
Oct 17, 2018

Conversation

Bengejd
Copy link
Contributor

@Bengejd Bengejd commented Oct 4, 2018

Added cordova-plugin-last-cam

@wf9a5m75
Copy link
Contributor

wf9a5m75 commented Oct 4, 2018

Only iOS ...

@Bengejd
Copy link
Contributor Author

Bengejd commented Oct 4, 2018

@wf9a5m75 correct. I have not implemented an Android version of the plugin yet, but that is in the works. Is it a problem that it only targets IOS for now? I know there are a number of plugins in @ionic-native that only target one platform or the other.

@wf9a5m75
Copy link
Contributor

wf9a5m75 commented Oct 4, 2018

Well, I only manage the google-maps wrapper.
Accepting your PR is in charge of ionic team.

I just surprise your plugin supports only iOS because your plugin subtitle is The last Cordova camera plugin you'll ever download.

@Bengejd
Copy link
Contributor Author

Bengejd commented Oct 4, 2018

That makes sense. I'll add in a disclaimer that it is only for IOS. I don't have an Android device to test on right now, so I have limited means to implement the Android version. I appreciate your feedback though.

@danielsogl danielsogl added new-plugin target: minor This PR is targeted for the next minor release labels Oct 11, 2018
@danielsogl danielsogl self-assigned this Oct 11, 2018
@danielsogl danielsogl merged commit 99cebcb into danielsogl:master Oct 17, 2018
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-plugin target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants