Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfc): add NFC readerMode #2777

Merged
merged 8 commits into from
Oct 17, 2018
Merged

Conversation

stephendwolff
Copy link
Contributor

I opened an issue about this #2756, and have managed to add the reader mode in my fork.

Please could you merge my pull request, as it would be good to use the main release in my app

Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all package changes

This reverts part of commit 24a893f.
@danielsogl danielsogl changed the title **feat**(nfc) add NFC readerMode feat(nfc): add NFC readerMode Oct 17, 2018
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Oct 17, 2018
@danielsogl danielsogl self-assigned this Oct 17, 2018
@stephendwolff
Copy link
Contributor Author

i've reverted the package changes now. Thanks!

@stephendwolff
Copy link
Contributor Author

@danielsogl there are some constants in the phonegap plugin which should be included in the ionic-native plugin. How should they be declared / annotated?

  /**
   * Android NfcAdapter.enableReaderMode flags
   */
//  let FLAG_READER_NFC_A: number = 0x1;
//  const FLAG_READER_NFC_B: 0x2,
//  const FLAG_READER_NFC_F: 0x4,
//  const FLAG_READER_NFC_V: 0x8,
//  const FLAG_READER_NFC_BARCODE: 0x10,
//  const FLAG_READER_SKIP_NDEF_CHECK: 0x80,
//  const FLAG_READER_NO_PLATFORM_SOUNDS: 0x100,

@sfaizanh
Copy link
Contributor

@stephendwolff add this after https://github.com/ionic-team/ionic-native/blob/05dc6f7f0c51e5af9ec1e1b90448eed20bcc5571/src/%40ionic-native/plugins/nfc/index.ts#L78

  FLAG_READER = {
    NFC_A: 0,
    NFC_B: 0x2,
    NFC_F: 0x4,
    NFC_V: 0x8,
    NFC_BARCODE: 0x10,
    SKIP_NDEF_CHECK: 0x80,
    NO_PLATFORM_SOUNDS: 0x100,
  };

@danielsogl danielsogl merged commit 2aa73b5 into danielsogl:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants