-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nfc): add NFC readerMode #2777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all package changes
This reverts part of commit 24a893f.
i've reverted the package changes now. Thanks! |
@danielsogl there are some constants in the phonegap plugin which should be included in the ionic-native plugin. How should they be declared / annotated?
|
@stephendwolff add this after https://github.com/ionic-team/ionic-native/blob/05dc6f7f0c51e5af9ec1e1b90448eed20bcc5571/src/%40ionic-native/plugins/nfc/index.ts#L78
|
Thanks @sfaizanh
I opened an issue about this #2756, and have managed to add the reader mode in my fork.
Please could you merge my pull request, as it would be good to use the main release in my app