Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(line-login): add plugin #2782

Merged
merged 5 commits into from
Nov 2, 2018
Merged

feat(line-login): add plugin #2782

merged 5 commits into from
Nov 2, 2018

Conversation

nrikiji
Copy link
Contributor

@nrikiji nrikiji commented Oct 18, 2018

No description provided.

@danielsogl danielsogl changed the title add line-login feat(line-login): add plugin Oct 27, 2018
@danielsogl danielsogl self-assigned this Oct 27, 2018
@danielsogl danielsogl added new-plugin target: minor This PR is targeted for the next minor release labels Oct 27, 2018
* @return {Promise<any>}
*/
@Cordova()
initialize(param: any): Promise<any> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add typings

@danielsogl
Copy link
Owner

Because you are the maintainer of the plugin you should be able to add typing information to the return types.

@danielsogl danielsogl merged commit dc4183d into danielsogl:master Nov 2, 2018
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-plugin target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants