-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gao-de-location): add plugin #2857
Conversation
* @returns {Promise<any>} Returns a Promise that resolves with the success return, or rejects with an error. | ||
*/ | ||
@Cordova() | ||
getCurrentPosition(): Promise<any> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide the correct typings as an interface.
*/ | ||
@Plugin({ | ||
pluginName: 'GaoDeLocation', | ||
plugin: 'cordova-plugin-gaodelocation-chenyu', // npm package name, example: cordova-plugin-camera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the placeholder comments
/** | ||
* @name Gao De Location | ||
* @description | ||
* Get the current location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a better description. I'm not that familiar with Chinese so I don't know the difference between this plugin and the Cordova geolocation plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modification has been completed as required.
Do you need any other changes? |
No its fine. I will merge all open PR's tomorrow. |
�Through this plug-in, you can get the local location. Reverse Address Coding