Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cordova.plugin.zoom):add new plugin #2916

Merged
merged 1 commit into from
Feb 14, 2019
Merged

feat(cordova.plugin.zoom):add new plugin #2916

merged 1 commit into from
Feb 14, 2019

Conversation

carsonzoom
Copy link
Contributor

Hi,
This pull request includes a newly developed Cordova Plugin for using Zoom video conferencing services. For more information, please refer to https://github.com/zoom/zoom-sdk-ionic

Let me know if you have any questions. Thank you very much in advance.

@carsonzoom
Copy link
Contributor Author

Not sure what's going on, ran into the following error on CircleCi:

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ionic-native@5.0.0 lint: `gulp lint`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the ionic-native@5.0.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@afshawnlotfi
Copy link
Contributor

I am having the same problem right now. It's because their linter wants you to alphabetize the imports, but the problem is their code is the one that has this problem. Wasn't sure if I need to fix it.

@danielsogl danielsogl self-requested a review February 14, 2019 08:37
@danielsogl danielsogl self-assigned this Feb 14, 2019
@danielsogl danielsogl added the target: minor This PR is targeted for the next minor release label Feb 14, 2019
@danielsogl danielsogl merged commit 50e0534 into danielsogl:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants