Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(device-accounts): update plugin source #2976

Merged
merged 4 commits into from
Apr 19, 2019
Merged

feat(device-accounts): update plugin source #2976

merged 4 commits into from
Apr 19, 2019

Conversation

xunholy
Copy link
Contributor

@xunholy xunholy commented Apr 3, 2019

Fixed: Device account does not support android 8.0 permissions update. Read more here https://developer.android.com/about/versions/oreo/android-8.0-changes

Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes from the package-lock.json file

@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Apr 7, 2019
@xunholy
Copy link
Contributor Author

xunholy commented Apr 7, 2019

@danielsogl addressed package-lock.json comment, has been reverted back to previous commit 49d7ca7

@xunholy
Copy link
Contributor Author

xunholy commented Apr 16, 2019

BUMP @danielsogl

@danielsogl danielsogl changed the title feat: updating device account wrapper with maintained fork with andro… feat(device-accounts): update plugin source Apr 17, 2019
@danielsogl danielsogl merged commit c063652 into danielsogl:master Apr 19, 2019
@xunholy
Copy link
Contributor Author

xunholy commented Apr 27, 2019

@danielsogl I'd like to make this updated version available in npm with minimal disruption.

https://www.npmjs.com/package/cordova-device-accounts

Can you add me as a contributor or remove the plugin and I'll re-publish?

Account: unholy050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants