Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in @ionic-native/nfc #2985

Closed
ab-kily opened this issue Apr 7, 2019 · 1 comment
Closed

typo in @ionic-native/nfc #2985

ab-kily opened this issue Apr 7, 2019 · 1 comment

Comments

@ab-kily
Copy link
Contributor

ab-kily commented Apr 7, 2019

I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request

Current behavior:
The problem in @ionic-native/nfc plugin. There is a method called makeReadyOnly(), but it seem there is a typo.

Expected behavior:
That method should be called makeReadOnly(), as in its phonegap-nfc parent.

Steps to reproduce:

Related code:
https://github.com/ionic-team/ionic-native/blob/master/src/%40ionic-native/plugins/nfc/index.ts

  /**
   * Makes a NFC tag read only. **Warning** this is permanent.
   * @returns {Promise<any>}
   */
  @Cordova()
  makeReadyOnly(): Promise<any> {
    return;
  }

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

@rodrigograca31
Copy link

@ab-kily is right. should be makeReadOnly

Original function: https://github.com/chariotsolutions/phonegap-nfc#nfcmakereadonly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants