Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng1): use $q promises instead of the native Promise #378

Merged
merged 1 commit into from
Jul 31, 2016
Merged

fix(ng1): use $q promises instead of the native Promise #378

merged 1 commit into from
Jul 31, 2016

Conversation

mattlewis92
Copy link
Contributor

This is a partial fix for #348 and #367 (ES6 promise's are currently given priority over ng1's $q so a scope.$apply is required for all promise callbacks as $q is never actually used).

The other half involves using an observable to trigger a digest which should be possible by using the rxjs scope scheduler.

@ihadeed ihadeed merged commit 817a434 into danielsogl:master Jul 31, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 31, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants