Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] $refresher-icon-color don't modify spinner color #10479

Closed
ramoncarreras opened this issue Feb 17, 2017 · 3 comments
Closed

[BUG] $refresher-icon-color don't modify spinner color #10479

ramoncarreras opened this issue Feb 17, 2017 · 3 comments

Comments

@ramoncarreras
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[X] 2.x

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] support request

Current behavior:
Having changed the $refresher-icon-color sass variable does not change the color of the spinner.
Works as expected with arrow-up and arrow-down icons.

Expected behavior:
The color of spinner changes.

Steps to reproduce:
Overwrite $refresher-icon-color:

$refresher-icon-color: #0f0;

Add ionic refresher:

<ion-content>

  <ion-refresher (ionRefresh)="doRefresh($event)">
    <ion-refresher-content></ion-refresher-content>
  </ion-refresher>

</ion-content>
@Component({...})
export class NewsFeedPage {

  doRefresh(refresher) {
    console.log('Begin async operation', refresher);

    setTimeout(() => {
      console.log('Async operation has ended');
      refresher.complete();
    }, 2000);
  }

}

Try it.

Ionic info:

Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.1
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.2
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: macOS Sierra
Node Version: v7.1.0
Xcode version: Xcode 8.2.1 Build version 8C1002
@ramoncarreras ramoncarreras changed the title $refresher-icon-color don't modify spinner color [BUG] $refresher-icon-color don't modify spinner color Feb 17, 2017
@jgw96
Copy link
Contributor

jgw96 commented Feb 17, 2017

Thanks for opening an issue with us, we will look into this.

@ramoncarreras
Copy link
Author

ramoncarreras commented Feb 27, 2017

Same with $infinite-scroll-loading-color.

#10574

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants