Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(refresher): white line underneath the navbar #10994

Closed
dylanvdmerwe opened this issue Mar 31, 2017 · 7 comments
Closed

bug(refresher): white line underneath the navbar #10994

dylanvdmerwe opened this issue Mar 31, 2017 · 7 comments

Comments

@dylanvdmerwe
Copy link
Contributor

Ionic version: (check one with "x")
[ ] 1.x
[x] 2.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
If you put an ion-refresher in your page, a white line appears underneath the navigation bar which is especially noticeable when the navbar and surrounding colors are dark. As soon as I remove the ion-refresher the white line goes away.

image

Expected behavior:
Adding an ion-refresher should not make such visible changes to the navbar.

Related code:

  <ion-refresher (ionRefresh)="refreshForms($event)">
    <ion-refresher-content pullingText="Pull to refresh forms" refreshingText="Loading forms..."></ion-refresher-content>
  </ion-refresher>

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.5.0
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.0
ios-sim version: 5.0.10
OS: macOS Sierra
Node Version: v6.9.5
Xcode version: Xcode 8.3 Build version 8E162
@jgw96 jgw96 added the v2 label Mar 31, 2017
@jgw96
Copy link
Contributor

jgw96 commented Mar 31, 2017

Interesting issue, thanks for opening! We will take a look at this.

@brandyscarney
Copy link
Member

A workaround is to add this to the variable.scss file:

$refresher-border-color: transparent;

I need to see if we can remove this border, I'm not sure why it's there. cc @manucorporat

@dylanvdmerwe
Copy link
Contributor Author

Thanks @brandyscarney

Workaround seems to do the trick.

@manucorporat
Copy link
Contributor

@brandyscarney no idea, maybe git blame?

@Manduro
Copy link
Contributor

Manduro commented Jun 12, 2017

The border looks good when using a refresher on a list, like in the api demo. It would be weird without it. http://ionicframework.com/docs/api/components/refresher/Refresher/

It should only be visible when pulling though. A style exists for this already:

.has-refresher > .scroll-content {
  margin-top: -1px;
}

Problem is that this style is overridden by the margins that are dynamically added to .scroll-content to compensate for header and footer heights.

@Manduro
Copy link
Contributor

Manduro commented Jun 12, 2017

Fix submitted! #12015

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants