fix(list-header): RTL fix for list-header #11328
Conversation
RTL fix (scss changes) for list-header for wp, ios and android platform
|
Would you mind adding a before / after screenshot? |
|
@manucorporat after |
| @@ -182,6 +182,10 @@ $list-ios-header-background-color: transparent !default; | |||
| background: $list-ios-header-background-color; | |||
| } | |||
|
|
|||
| [dir="rtl"] .list-header-ios { | |||
| padding-right: $list-ios-header-padding-left; | |||
There was a problem hiding this comment.
maybe renaming the css variable to $list-ios-header-padding-start?
thoughts @AmitMY @brandyscarney
There was a problem hiding this comment.
@manucorporat
@sijav and I had this discussion before.
Changing it to start will require support for left. which is possible and awesome, but should imo be a different PR, changing all relevant variables to start/end and adding the correct depredations, so in v4 can have a clean variables naming
There was a problem hiding this comment.
@AmitMY fair enough, LGTM
|
BTW, thanks everybody involved in these awesome RTL fixes. I am so happy we can finally support this, and 100% driven by the community!! |
|
Thank you again! Great work. 😄 |
Short description of what this resolves:
RTL fix (scss changes) for list-header for wp, ios and android platform
Changes proposed in this pull request:
Ionic Version: 2.x / 3.x
Fixes: #11211