Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature mismatch in Searchbar causing AOT builds to fail #11598

Closed
kulshekhar opened this issue May 10, 2017 · 3 comments
Closed

Signature mismatch in Searchbar causing AOT builds to fail #11598

kulshekhar opened this issue May 10, 2017 · 3 comments

Comments

@kulshekhar
Copy link
Contributor

kulshekhar commented May 10, 2017

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
AOT build fails with a message:

ERROR in .....ionic-angular/components/searchbar/searchbar.d.ts.Searchbar.html (2,387): Supplied parameters do not match any signature of call target.

Expected behavior:
The AOT build should succeed

Steps to reproduce:
This was caught in a Travis job when upgrading to 3.2.

Other information:
This is probably caused due to mismatch in the signatures for the inputBlurred and inputFocused methods in searchbar.ts. These used to have a parameter which was removed in the latest release. The corresponding calls from the template, however, were not updated.

@kulshekhar
Copy link
Contributor Author

It would be great if you can create a minor release if/when this is fixed. I can't be the only one whose CI builds are breaking :)

@brandyscarney
Copy link
Member

Thanks for the issue and the PR! I've released a nightly with your fix in it:

npm install --save --save-exact ionic-angular@3.2.0-201705111630

Please keep this issue open. We want to fix our build script so that we get these errors before we release. 🙂

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants