fix(rtl): add icon-start and icon-end attributes #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
changed the title
|
@brandyscarney If icon was already fixed in v4, and already has |
|
@AmitMY I'm good with merging it for the rename so master has it, but can you separate out the changes to the e2e tests into a different PR? I want to run snapshot with the new css & old markup and make sure it still looks the same. |
|
@brandyscarney I reverted all of the changes to the testing |
AmitMY
added a commit
to AmitMY/ionic
that referenced
this pull request
Jun 6, 2017
* feat(icon): add start/end * fix(icon): add all relevant deprecations * fix(deprecation): add deprecation to missing selector * revert(tests): revert icon-start/end from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
icons position on rtl
Changes proposed in this pull request:
icon-startandicon-endnotationsicon-leftandicon-righticon-leftandicon-rightWhy not fully support
icon-leftandicon-right?Because it is a css styling only, there will need to be use of
floatordirwhich are both undesired, so the only remaining option is to deprecate the old wayIonic Version: 3.x