fix(select): make select with no options return undefined when OK is pressed #11968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
suggested changes
Jun 8, 2017
| @@ -322,7 +322,9 @@ export class AlertCmp { | |||
| this.d.inputs.forEach(i => { | |||
| values[i.name] = i.value; | |||
| }); | |||
| return values; | |||
|
|
|||
There was a problem hiding this comment.
could we implement this with an early return instead?
if (this.d.inputs.length === 0) {
return undefined;
}
this way we don't allocate values and Object.keys()'s array.
There was a problem hiding this comment.
Yeah that sounds like a better idea. I'll commit that soon.
zakton5
commented
Jun 8, 2017
|
Merged!!! thanks a lot for the PR! @zakton5 !! |
|
No problem :) @manucorporat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Opening a select without options in it and then pressing Okay resulted in the bound model being set to
{}Changes proposed in this pull request:
The current code instantiates an empty object and attempts to put values of any text inputs in that object. I've added a check to determine if that object has any properties in it and, if it does not, it returns
undefinedinstead of that empty object.Ionic Version:3.x
Fixes: #10435