Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tap-click): activated state is kept on activable element #13258

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

jrmlt
Copy link

@jrmlt jrmlt commented Oct 27, 2017

Short description of what this resolves:

The .activated class is kept on a activable element when the finger or mouse is released on an non-activable element (#13044)

Changes proposed in this pull request:

Keep previous activatableEle between pointerStart and pointerEnd method

Ionic Version: 3.x

Fixes: #13044

@kensodemann kensodemann self-requested a review October 27, 2017 15:07
@kensodemann kensodemann added this to the 3.9.0 milestone Oct 27, 2017
@kensodemann kensodemann self-assigned this Oct 27, 2017
Copy link
Member

@kensodemann kensodemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kensodemann kensodemann merged commit 5742540 into ionic-team:master Oct 27, 2017
@kensodemann
Copy link
Member

Thank you for the pull request.

@jrmlt
Copy link
Author

jrmlt commented Oct 28, 2017

Glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants