Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Import Transition Controller #14476

Closed
Maraket opened this issue May 15, 2018 · 2 comments
Closed

Unable to Import Transition Controller #14476

Maraket opened this issue May 15, 2018 · 2 comments
Labels
ionitron: v3 moves the issue to the ionic-v3 repository

Comments

@Maraket
Copy link

Maraket commented May 15, 2018

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
I am currently trying to extend the Tabs component for a project, and in doing so need to extend the Tab component. Though in extending, I had to put in my own reference to my extended Tabs component to pass in, this exposing the need to refer to the TransitionController which is not available to be imported outside of the ionic module.

I have attempted to create a mock TransitionController, but find that I am funning into the same error:

#5331
trades-tab.zip

Expected behavior:
Be able to import TransitionController (or I might not be using providers in the right way).

Other Info:
Found #10264 though found that the unit testing framework provided in #5331 doesn't include suggestions on how to mock TransitionController

Potential fix: Add export { TransitionController } from './transitions/transition-controller'; in ionic/src/index.ts.
Ionic Framework Version: 3.9.2
Ionic CLI Version: 3.20.0
OS: Ubuntu 16.04
Node Version: v8.11.0

@ionitron-bot ionitron-bot bot added the triage label May 15, 2018
@Ionitron Ionitron added the ionitron: v3 moves the issue to the ionic-v3 repository label Nov 29, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 29, 2018

This issue has been automatically identified as an Ionic 3 issue. We recently moved Ionic 3 to its own repository. I am moving this issue to the repository for Ionic 3. Please track this issue over there.

If I've made a mistake, and if this issue is still relevant to Ionic 4, please let the Ionic Framework team know!

Thank you for using Ionic!

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 29, 2018

Issue moved to: ionic-team/ionic-v3#481

@ionitron-bot ionitron-bot bot closed this as completed Nov 29, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 29, 2018
@ionitron-bot ionitron-bot bot removed the triage label Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ionitron: v3 moves the issue to the ionic-v3 repository
Projects
None yet
Development

No branches or pull requests

2 participants