Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: bug: Ion spinner not spinning in Windows Phone 8.1 #3480

Closed
VeldMuijz opened this issue Apr 7, 2015 · 4 comments
Closed

bug: bug: Ion spinner not spinning in Windows Phone 8.1 #3480

VeldMuijz opened this issue Apr 7, 2015 · 4 comments
Assignees
Milestone

Comments

@VeldMuijz
Copy link

Type: bug

Platform: mobile webview

Hi,
I'm creating an app for Windows Phone 8.1, Android and iOS.
The spinner directive doesn't show a spinning spinner in WP8.1 just a static image.

The spinning css look like it uses css animations that are supported by Internet Explorere 11 and I don't know where else to look.

Spinners do work on Android and iOS.

CodePen.io example

Example gif (left is windows, right is android):
github example spinner

@VeldMuijz VeldMuijz changed the title bug: Ion spinner not spinning in Windows Phone 81 bug: bug: Ion spinner not spinning in Windows Phone 8.1 Apr 7, 2015
@perrygovier
Copy link
Contributor

Thanks @VeldMuijz, we'll look in to it

@perrygovier
Copy link
Contributor

@VeldMuijz the problem is that IE doesn't support smil animations. since the android spinner uses a timing function instead of smil animation, I set that to be the default spinner on windows phone. That's not a great solution, but it's what we're going to do for now. You can add CSS animations to some of the spinners to get them looking right as well. Something like:

.platform-windowsphone8 {
  .spinner-ios,
  .spinner-ios-small,
  .spinner-circles,
  .spinner-crescent{
    svg {
      animation:spin 1250ms linear infinite;
    }
  }
  .spinner-spiral svg{
    animation:spin 750ms linear infinite;
  }
}
@-webkit-keyframes spin {
  from { -webkit-transform: rotate(0deg) }
  to { -webkit-transform: rotate(360deg) }
}
@keyframes spin
{
  from { transform:rotate(0deg); }
  to { transform:rotate(360deg); }
}

but the animation isn't perfect so we don't plan on adding it to the core

@ghenry22
Copy link

This catches windows phone but does not catch the new windows platform which has the same issue. Could be changed to the below to also catch the "windows" platform?

This may be addressed in Ionic 1.2.1 which has official windows platform support, haven't tested yet.

  if (ionic.Platform.platform() === 'windowsphone' || ionic.Platform.platform() === "windows") {
    override = 'android';
  }

@jdnichollsc
Copy link

@perrygovier please, add in the Ionic website a page of tips to use Ionic Framework. This info is very useful! :)

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants