Button border colors hard coded transparent

[joeljameswatson]

In Ionic 1.2.0 the button border styles appear to be hardcoded to transparent through a mixin. This seems to make creating custom styles more difficult and less maintainable. I suggest this could be set as a variable.

Please see this commit:

21e54be

[ghost]

+1 I just updated ionic to 1.2.1 and all the borders disappeared.

Is this a feature or a bug?

[jgw96]

@asanin-2sol Would you mind making a codepen or giving us a code example so that we can repro this issue? Thanks!

[ghost]

@jgw96 My main problem is with button bars, having no borders makes the following example look like a single button with three labels rather than three buttons in a bar.

<div class="button-bar">
  <a class="button">First</a>
  <a class="button">Second</a>
  <a class="button">Third</a>
</div>

Also, the way this looks does not correspond to the way button bars look in the documentation, where the borders are not transparent.

Hope this helps.

[danbucholtz]

Hi @gness and @joeljameswatson,

I have updated the sass. Please take a look and let me know if any changes are required and if this works for you. In the mean time I am going to close this issue. Thanks for contributing and letting us know.

Thanks,
Dan

[andischerer]

Hi @danbucholtz,

i have left a comment on your commit. Currently there is no chance to set a user defined value to the introduced scss variables $button-default-border and $button-default-active-border.

[danbucholtz]

Hi @andischerer,

Can you do a PR with the changes you'd like to see. I'll happily work with you to get it merged quickly. Please let me know.

Thanks!
Dan

[andischerer]

@danbucholtz here you are

[danbucholtz]

Nice! I'll test and merge. In the off chance I forget, just bug me about it again. Thanks for doing this!

Thanks,
Dan

[UnVoiding]

@danbucholtz This issue seems to be resolved but $button-default-border and $button-default-active-border is still hard-coded