Nav.pop()/remove() etc. does not call onDidDismiss()

[manucorporat]

Dismissing modals, alerts, toasts or actionsheets by interacting directly with the NavController causes onDidDismiss() and onWillDismiss() to not be called.

Should we move the callbacks from ViewController.ts

  dismiss(data?: any, role?: any, navOptions: NavOptions = {}): Promise<any> {
    let options = merge({}, this._leavingOpts, navOptions);
    this._onWillDismiss && this._onWillDismiss(data, role);
    if (!this._nav) {
      return Promise.resolve();
    }
    return this._nav.remove(this._nav.indexOf(this), 1, options).then(() => {
      this._onDidDismiss && this._onDidDismiss(data, role);
      this._onDidDismiss = null;
      return data;
    });
  }

to: nav-controller-base.ts ?

Use case, while trying to fix this issue #8219, I found out that this.nav.popAll() does not call the mentioned callbacks.

ping @adamdbradley @brandyscarney

[manucorporat]

This is very important to be fixed as soon as possible. With android go back button working properly this issue is more important than ever.

ping @adamdbradley @brandyscarney

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.