Skip to content

[Vue] Tree-shakeable controllers from @ionic/core #19573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

michaeltintiuc
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Initial introduction of tree-shakeable controllers from @ionic/core as a replacement to proxy based ones.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently the controllers are accessed via a global Vue.$ionic object which is not tree-shakeable.

What is the new behavior?

The previous behavior is kept and a deprecation warning is added.
It is now also possible to import controllers directly via import { modalController } from '@ionic/vue'

Does this introduce a breaking change?

  • Yes
  • No

@ionitron-bot ionitron-bot bot added the package: vue @ionic/vue package label Oct 8, 2019
@liamdebeasi
Copy link
Contributor

Thanks for the PR! This is resolved in Ionic Vue for Vue 3.

@liamdebeasi liamdebeasi closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants