[Vue] Tree-shakeable controllers from @ionic/core #19573
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Initial introduction of tree-shakeable controllers from @ionic/core as a replacement to proxy based ones.
Please check the type of change your PR introduces:
What is the current behavior?
Currently the controllers are accessed via a global
Vue.$ionic
object which is not tree-shakeable.What is the new behavior?
The previous behavior is kept and a deprecation warning is added.
It is now also possible to import controllers directly via
import { modalController } from '@ionic/vue'
Does this introduce a breaking change?