Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add X logo #1371

Merged
merged 2 commits into from
May 1, 2024
Merged

feat: add X logo #1371

merged 2 commits into from
May 1, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 30, 2024

resolves #1249

We originally discussed replacing the Twitter logo with X, but I could not find a way to keep the new icon available under the logo-twitter name and under logo-x. If we just did logo-x then the logo-twitter name would break which would be a breaking change. As a result, I decided to keep both for now.

@liamdebeasi liamdebeasi marked this pull request as ready for review April 30, 2024 21:01
@liamdebeasi liamdebeasi requested review from a team and sean-perkins and removed request for a team April 30, 2024 21:02
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elon will finally stop DM'ing me about this.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi merged commit 0963fe2 into feature-7.4 May 1, 2024
6 checks passed
@liamdebeasi liamdebeasi deleted the logo-x branch May 1, 2024 18:41
@liamdebeasi liamdebeasi mentioned this pull request May 1, 2024
@mimoudix
Copy link

mimoudix commented May 1, 2024

Thank you, spotify when ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants