Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Element Missing On Close and On Cancel Event Handler in JSX #1049

Closed
bassettsj opened this issue Aug 30, 2018 · 1 comment
Closed
Assignees

Comments

@bassettsj
Copy link

Stencil version:

 @stencil/core@0.12.4

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

[ ERROR ]  TypeScript: src/components/my-component/my-component.tsx:31:10
           Property 'onClose' does not exist on type
           'DialogHTMLAttributes'.

     L31:            onClose={this.onClose}
     L32:            onCancel={this.onClose}

https://github.com/bassettsj/stencil-dialog-element-bug

Expected behavior:

Expected to recognize the onClose and onCancel event handlers for the HTMLDialogElement

Steps to reproduce:
https://github.com/bassettsj/stencil-dialog-element-bug

  1. remove the @ts-ignore comment and run npm run build

Other information:

Fix would only be adding this to the type definitions so it will work as expected.

@arjunyel
Copy link
Contributor

I think I added the onClose but I didnt see the onCancel in the spec? I very possibly missed it #1348 https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element

@stenciljs stenciljs locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants