Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI does not parse/escape parameters correctly #1296

Closed
nagysz opened this issue Dec 20, 2018 · 1 comment
Closed

CLI does not parse/escape parameters correctly #1296

nagysz opened this issue Dec 20, 2018 · 1 comment

Comments

@nagysz
Copy link

nagysz commented Dec 20, 2018

Stencil version:

 @stencil/core@0.16.1

I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
After upgarding to version 0.16.1 (two apps, 0.15.0 and some older as well, other community members reported also strange behaviour upgrading from 0.16.0) the CLI does not parse/escape command line parameters correctly. The behaviour is experienced on Windows 10 and Linux as well (did not have the chance to verify on a mac).
The erroneous behaviour is connected the additional parameters either as part of an npm script or appended manually.

Expected behavior:
npm run-script test executes tests just as npm run test where the test npm script is as follows:

"test": "stencil test --spec --e2e"

Steps to reproduce:

  1. Take a component starter with @stencil/core version 0.16.1
  2. Execute npm run-script test or provide command line parameters (such as test pattern) manually

Related code:

npm run-script test yields:

No tests found
In C:\workspace\slds-custom-components
  263 files checked.
  testMatch: **/*(*.)+(e2e|spec).+(ts)?(x) - 16 matches
  testPathIgnorePatterns: C:\\workspace\\slds-custom-components\.vscode,C:\\workspace\\slds-custom-components\.stencil,C:\\workspace\\slds-custom-components\\node_modules,C:\\workspace\\slds-custom-components\\dist,C:\\workspace\\
slds-custom-components\\www - 60 matches
Pattern: run-script - 0 matches

Other information:
Jest uses the micromatch library that caused inconveniences with the major release of 3.0.0. It has been rolled back with Jest version 23.4 though.

@ionitron-bot ionitron-bot bot added the triage label Dec 20, 2018
@adamdbradley
Copy link
Contributor

This should be fixed in the latest version. If it's still a problem, would you be able to create an issue with a thorough description on how to replicate this? Thanks

@adamdbradley adamdbradley added bug and removed triage labels Jan 2, 2020
@ionic-team ionic-team locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants