Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lifecycles): Defer connectedCallback until all components registered #1930

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

robinsummerhill
Copy link
Contributor

@robinsummerhill robinsummerhill commented Oct 8, 2019

This PR fixes issue #1261 and adds a specific Karma e2e test for the following case where lifecycle events are out of order for nested components:

<cmp-c>
  <cmp-b>
    <cmp-a></cmp-a>
  </cmp-b>
</cmp-c>

@manucorporat manucorporat merged commit 0f302eb into ionic-team:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants