fix(jest): change package used to import runCli #2387
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using jest-cli to import runCli breaks in jest@25 and @jest/core must be used instead. This package started shipping in jest@24.3.0 so its safe to use it as Stencil installs jest@24.9.
|
FYI I did this using latest version of stencil and it breaks giving me a ton of |
|
Awesome thanks! And following this up with a few more updates, thanks for the PR!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Using jest-cli to import runCli breaks in jest@25 and @jest/core must be used instead.
This package started shipping in jest@24.3.0 so its safe to use it as Stencil installs jest@24.9.
Fixes #2168
Testing instructions
npm run buildnpm linkOn a project that uses Stencil (for example, stencil-component-starter), run:
npm testnpm install jest@25 jests-cli@25npm link @stencil/corenpm test