Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components not loading in Safari 10.1 #2392

Closed
maxjustus opened this issue Apr 24, 2020 · 6 comments
Closed

Components not loading in Safari 10.1 #2392

maxjustus opened this issue Apr 24, 2020 · 6 comments
Labels

Comments

@maxjustus
Copy link
Contributor

Stencil version:

 @stencil/core@1.12.4

I'm submitting a:

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

When attempting to load a page with stencil components in Safari 10.1 on both Mac OS and iOS no custom elements on the page get upgraded/hydrated, and no js errors appear in the console.

Screen Shot 2020-04-24 at 3 26 43 PM

Prior to upgrading to 1.12.14 we were running 1.5.3 and using server side code to only serve the ES modules JS file to Safari 10.1 as a workaround for 10.1's issue with loading and evaluating both the type="module" and nomodule files and we were able to get it working. Since the change that makes Safari 10.1 use the es5 bundle we removed that business logic but even with that change nothing is working.

Expected behavior:

Components should load in Safari 10.1

Steps to reproduce:

You can actually observe this issue on the ionic framework docs site by loading up one of the example pages in Safari 10.1 https://ionicframework.com/docs/demos/api/input/index.html
You will see a blank page, and if you open the console, you'll see no errors. Inspecting the DOM will reveal that none of the components on the page have a "hydrated" class and they're all empty.

@ionitron-bot ionitron-bot bot added the triage label Apr 24, 2020
@manucorporat
Copy link
Contributor

This should be fixed in latest stencil, there is a settting in stencil.config.ts called extras enable the safari10 option by setting it to true.

@warapitiya
Copy link
Contributor

warapitiya commented Jul 28, 2020

I can confirm that this is still not working.

Browser:
image

Tested on Stencil: v1.2.0 and v1.7.1 both.

Issue Repo: https://github.com/warapitiya/stencil-safari10

  1. Clone the issue repo.
  2. Install NPM dependencies.
  3. npm run build
  4. npx serve
  5. Navigate to http://localhost:5000/example on Safari 10

@FortinFred
Copy link

FortinFred commented Dec 7, 2020

Same here, it's not working on iOS 10.3. Stencil v2!

This issue should be reopened!

@linuxonrails
Copy link

Same here! Last Stencil version with Safari 10.3.

It's important. Please, reopen!

@linuxonrails
Copy link

linuxonrails commented Jun 28, 2022

You can actually observe this issue on the ionic framework docs site by loading up one of the example pages in Safari 10.1 https://ionicframework.com/docs/demos/api/input/index.html You will see a blank page, and if you open the console, you'll see no errors. Inspecting the DOM will reveal that none of the components on the page have a "hydrated" class and they're all empty.

With Safari 11 in https://ionicframework.com/docs/demos/api/input/index.html I have javascripts errors:

SyntaxError: Unexpected identifier 'i'. Expected a ';' following a return statement. undefinedpromiseReactionJob @ (program):1

With Safari 10, nothing happens (no render, no errors) 😞

Please, @bluethunder626!

@linuxonrails
Copy link

@manucorporat Can you confirm that it's fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants