fix(testing): MockResponse404 is not ok #2420
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MockResponse404
extends fromMockResponse
which setsok
totrue
by default. However,ok
should only betrue
, if the status code is within the 2xx range.Alternatively, we could change the
ok
property ofMockResponse
to a getter:However, by doing that
ok
would be readonly and that is probably a breaking change. 🤔