Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CLI args of test names not propagated to Jest #3825

Closed
duhem-s opened this issue Nov 16, 2022 · 7 comments
Closed

bug: CLI args of test names not propagated to Jest #3825

duhem-s opened this issue Nov 16, 2022 · 7 comments
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@duhem-s
Copy link

duhem-s commented Nov 16, 2022

Stencil version:

 @stencil/core@2.19.x

Current behavior:
I used to do npm run test:unit -- mg-form to only test my mg-form component but since the version 2.19.x I'm not able to do so, all my unit tests are launched.

My test:unit script run stencil test --spec.

Expected behavior:
Be able to run a specific test file.

GitHub Reproduction Link:
https://github.com/duhem-s/stencil-cli

Other information:

With the command: npm run test -- second on the GH reproduction :

With stencil@2.18.1
image

With stencil@2.19.0
image

@ionitron-bot ionitron-bot bot added the triage label Nov 16, 2022
@rwaskiewicz rwaskiewicz self-assigned this Nov 16, 2022
@rwaskiewicz
Copy link
Contributor

Thanks @duhem-s! I confirmed this was introduced in v2.19.0. I'm going to label this for the team to take a closer look

@rwaskiewicz rwaskiewicz added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label Nov 16, 2022
@ionitron-bot ionitron-bot bot removed the triage label Nov 16, 2022
@rwaskiewicz rwaskiewicz changed the title bug: CLI arguments broken bug: CLI args of test names not propagated to Jest Nov 16, 2022
@rwaskiewicz rwaskiewicz removed their assignment Nov 16, 2022
@alicewriteswrongs
Copy link
Contributor

Is it possible this is a duplicate of #3785?

@alicewriteswrongs
Copy link
Contributor

I just confirmed that this is the same issue as #3785, I have a fix which fixes the problem in both the reproduction for that issue and this one. I'm going to open a PR for that shortly, but I'm going to close this issue for bookkeeping purposes.

@duhem-s
Copy link
Author

duhem-s commented Nov 17, 2022

Hi @alicewriteswrongs 👋

I opened a new one #3828 do you think your PR will also fix this ?

@alicewriteswrongs
Copy link
Contributor

Unfortunately that does look like a separate issue - at present we have a manually-defined set of short aliases like that which we support, and -u is, sadly, not among them at present 😢

@alicewriteswrongs
Copy link
Contributor

Ok so I just realized, belatedly, that #3785 is not the same issue as this one, so I'm going to re-open this issue so we can keep track of making sure that our next release fixes it.

Sorry for the noise!

@rwaskiewicz
Copy link
Contributor

@duhem-s 👋

I was able to verify that as of Stencil v2.20.0, this issue has been fixed using your reproduction case:
Screenshot 2022-12-05 at 1 02 03 PM

I'm going to close this as a result. Thanks again for the detailed reproduction case, it was helpful both in triaging the issue and verifying the fix worked!

Should this bug reappear, please feel free to open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

No branches or pull requests

3 participants