bug: jest takes --max-workers as a file pattern when it is not specified and a pattern is provided

[andrew9994]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

> 2.19.0

Current Behavior

When stencil test is called with a file pattern, without specifying the max workers in the pool like this:

npx stencil test --e2e -- some-file-name.e2e.ts

stencil adds the --max-workers argument to the end of the passed arguments, and gets passed to jest like this:

jest args: --e2e -- some-file-name.e2e.ts --max-workers=8

but jest expects that '--' is only followed by filename patterns and that all flags like --json are before it in the argument list, therefore the --max-workers has no effect and indeed jest interprets it as a file pattern:

Ran all test suites matching /some-file-name.e2e.ts|--max-workers=8/i.

The bug got introduced with: 8a221e8

Expected Behavior

Jest --max-workers arg should be passed before -- when not specified.

System Info

No response

Steps to Reproduce

Run a test with a file pattern, without specifying the num of max-workers. Like:
npx stencil test --e2e -- some-file-name.e2e.ts

Code Reproduction URL

https://github.com/ionic-team/ionic-framework

Additional Information

I would open a PR to solve this issue.

[rwaskiewicz]

Hey @andrew9994 👋

We've added #3827 since the commit you linked in:

The bug got introduced with: 8a221e8

which sounds very much like the issue you're seeing.

Can you please add a minimal reproduction URL for the team to look at? Thanks!

[ionitron-bot]

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

[andrew9994]

Sorry, I noticed that it was fixed already in eb44060, but it is not yet released.

[rwaskiewicz]

Ah, not a problem! I expect this to be released next Monday, as a part of Stencil 2.20.0

[andrew9994]

Thanks @rwaskiewicz !

[rwaskiewicz]

@andrew9994

👋 I wanted to follow up and let you know that v2.20.0 has been released with the fix for this issue. Should the fix in the release not solve the one you reported, please feel free to open a new issue. Thanks!