fix(runtime): always throw if component can not be loaded

[christian-bromann]

What is the current behavior?

Due to the fact we don't have strict null checks we missed this area where Cstr can be null at a point where we wanted to access a property (e.g. isProxied).

GitHub Issue Number:
fixes #5759

What is the new behavior?

I removed the condition that errors are only thrown if (BUILD.isDev || BUILD.isDebug) is truthy. It doesn't make much sense to me why we only would want this error to be elevated in these conditions.

Documentation

n/a

Does this introduce a breaking change?

• Yes
• No

Testing

n/a

Other information

n/a

[github-actions]

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9066955561/artifacts/1498044948

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.0-dev.1715620062.90a65d0.tgz.zip && npm install ~/Downloads/stencil-core-4.18.0-dev.1715620062.90a65d0.tgz

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1121 errors on this branch.

That's 4 fewer than on main! 🎉🎉🎉

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/dev-server/server-process.ts	32
src/compiler/prerender/prerender-main.ts	22
src/runtime/client-hydrate.ts	20
src/runtime/vdom/vdom-render.ts	20
src/screenshot/connector-base.ts	19
src/testing/puppeteer/puppeteer-element.ts	19
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/runtime/connected-callback.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/set-value.ts	13
src/compiler/output-targets/output-www.ts	12
src/compiler/transformers/test/parse-vdom.spec.ts	12
src/compiler/transformers/transform-utils.ts	12
src/mock-doc/test/attribute.spec.ts	12
src/compiler/build/compiler-ctx.ts	11

Our most common errors

Typescript Error Code	Count
TS2322	358
TS2345	345
TS18048	201
TS18047	77
TS2722	37
TS2532	24
TS2531	19
TS2454	14
TS2790	11
TS2352	9
TS2769	8
TS2416	7
TS2538	4
TS2493	3
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	245	NODE_TYPES
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	116	Env
src/compiler/app-core/app-data.ts	118	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

[alicewriteswrongs]

I think the change makes sense - j/w if you found any way to reproduce the failure case in a test so we can sort of make sure it fails the way we think it should?

[christian-bromann]

j/w if you found any way to reproduce the failure case in a test so we can sort of make sure it fails the way we think it should?

I looked into this and it doesn't seem to be straightforward. I am not able to import the internals in a way that would allow me to modify the runtime in order to reproduce this. The OP of the issue also mentioned that they are not able to reproduce given issue in a new Stencil project.

[alicewriteswrongs]

makes sense, I think we're good to go ahead then 👍