fix(runtime): SSR class handling breaks normal class handling #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lifecycle or render
- upgrade prettier to v2.3.2 - lock version to prevent breaking changes in minor versions - add prettier.dry-run package.json script - add pipeline action to evaluate format status - add prettierignore file for faster runs STENCIL-8: Add Prettier to Stencil
…lifecycle or render
…-error-boundaries
# Conflicts: # .prettierignore # package-lock.json # package.json # scripts/license.ts # scripts/release-tasks.ts # scripts/release.ts # scripts/utils/release-utils.ts # src/client/client-load-module.ts # src/hydrate/platform/proxy-host-element.ts # src/sys/node/node-sys.ts # test/browser-compile/src/utils/css-template-plugin.ts # test/karma/stencil.config.ts # test/karma/test-app/util.ts
# Conflicts: # src/hydrate/platform/proxy-host-element.ts
added 8 commits
August 30, 2022 22:17
johnjenkins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
#6082 caused a regression.
SSR logic, handling classes during the initial render / hydration of nodes would run all the time which would sometimes fail (#6115) and other times leave classes behind (#6114)
What is the new behavior?
SSR logic relating to classes during hydration now only runs if a) SSR hydration is a feature of the build & b) the component is being rendered for the first time.
Fixes: #6115
Fixes: #6114
Documentation
Does this introduce a breaking change?
Testing
Other information