-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): support watch for components with custom tag names #5767
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bd778b0
fix(runtime): support watch for components with custom tag names
christian-bromann 8e38478
add unit test
christian-bromann a8bb3b0
Update src/runtime/initialize-component.ts
christian-bromann 4a5e5b0
Merge branch 'main' into cb/custom-tag-watch
christian-bromann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
test/wdio/watch-native-attributes/custom-tag-name.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { h } from '@stencil/core'; | ||
import { render } from '@wdio/browser-runner/stencil'; | ||
|
||
import { WatchNativeAttributes } from '../test-components/watch-native-attributes.js'; | ||
|
||
describe('watch native attributes', () => { | ||
beforeEach(() => { | ||
customElements.define('some-custom-element', WatchNativeAttributes); | ||
render({ | ||
template: () => <some-custom-element aria-label="myStartingLabel"></some-custom-element>, | ||
}); | ||
}); | ||
|
||
it('triggers the callback for the watched attribute', async () => { | ||
const $cmp = $('some-custom-element'); | ||
await $cmp.waitForExist(); | ||
|
||
await expect($cmp).toHaveText('Label: myStartingLabel\nCallback triggered: false'); | ||
|
||
const cmp = document.querySelector('some-custom-element'); | ||
cmp.setAttribute('aria-label', 'myNewLabel'); | ||
|
||
await expect($cmp).toHaveText('Label: myNewLabel\nCallback triggered: true'); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this because we don't want the normal
.define
call to happen, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so we avoid registering all the components to the registry to test the behavior where user would do this manually.