-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request - Error when trying to set unusable version code #205
Comments
to add my two cents' worth here...
I feel like this falls outside the scope of things that Trapeze should be expected to cover.. while I do not know what it is in Google's ecosystem that imposes this "maximum value limitation" for the Android so if Trapeze did implement any special handling for this particular property, then any changes to these limitations would likely require changes in Trapeze as well. potentially breaking changes, depending on how it changes on Google's side.
similarly, I feel like this is also not something that Gradle should have any say in directly, as that in itself is a generic build system (and dependency manager, and and and...), whereas the value of this particular property is only relevant to the Android ecosystem (which simply uses Gradle). Gradle is just reporting an error based on the current build configuration requirements, as defined in Android-specific workflows, where even those requirements are distributed in separate "build config" packages, imported and parsed by Gradle at build time. some food for thought regarding an alternative way of handling this: I created version bump helper script for my own hybrid mobile projects that uses Trapeze to apply version updates, with steps along the way that gather and validate information from different sources (CLI args, current project, SemVer checks, etc) and conditionally prompts the user (using in this script, I simply use this effectively turns my native project "build identifier" field into something that is auto-incrementing, that both Google and Apple happily accept, is far easier to read than extrapolating |
Hi :)
I recently had a build issue on android because of a "small" problem:
In a project, we set the versionCode like
YYMMDD###
. Because of a minor error, the code was changed to generate not 3, but 4 digits at the end of that versionCode. That exceeded the maximum length allowed for this value (2100000000), but gradle only gave the following error (line 10 isversionCode
):Would it be possible to generate a warning/error when trying to set a versionCode higher than allowed with trapeze?
Or should I file an issue with gradle for a better error message?
Thanks
Marc
The text was updated successfully, but these errors were encountered: