-
Notifications
You must be signed in to change notification settings - Fork 154
/
build.fsx
434 lines (355 loc) · 15.1 KB
/
build.fsx
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
#r "nuget: Fun.Build, 1.1.2"
#r "nuget: Fake.Tools.Git, 6.0.0"
#r "nuget: Fake.IO.FileSystem, 6.0.0"
#r "nuget: Fantomas.Core, 6.3.1"
open Fun.Build
open Fake.Tools
module ScaffoldCodeFix =
open System
open System.IO
open Fake.Core
open Fake.IO.FileSystemOperators
open Fantomas.Core.SyntaxOak
let repositoryRoot = __SOURCE_DIRECTORY__
let AdaptiveServerStatePath =
repositoryRoot
</> "src"
</> "FsAutoComplete"
</> "LspServers"
</> "AdaptiveServerState.fs"
let TestsPath =
repositoryRoot
</> "test"
</> "FsAutoComplete.Tests.Lsp"
</> "CodeFixTests"
</> "Tests.fs"
let removeReturnCarriage (v: string) = v.Replace("\r", "")
let mkCodeFixImplementation codeFixName =
let path =
repositoryRoot
</> "src"
</> "FsAutoComplete"
</> "CodeFixes"
</> $"{codeFixName}.fs"
let content =
$"""module FsAutoComplete.CodeFix.%s{codeFixName}
open FSharp.Compiler.Symbols
open FSharp.Compiler.Syntax
open FSharp.Compiler.Text
open FsToolkit.ErrorHandling
open Ionide.LanguageServerProtocol.Types
open FsAutoComplete.CodeFix.Types
open FsAutoComplete
open FsAutoComplete.LspHelpers
// TODO: add proper title for code fix
let title = "%s{codeFixName} Codefix"
let fix
(getParseResultsForFile: GetParseResultsForFile)
: CodeFix =
fun (codeActionParams: CodeActionParams) ->
asyncResult {{
// Most code fixes have some general setup.
// We initially want to detect the state of the current code and whether we can propose any text edits to the user.
let fileName = codeActionParams.TextDocument.GetFilePath() |> Utils.normalizePath
// The converted LSP start position to an FCS start position.
let fcsPos = protocolPosToPos codeActionParams.Range.Start
// The syntax tree and typed tree, current line and sourceText of the current file.
let! (parseAndCheckResults:ParseAndCheckResults, line:string, sourceText:IFSACSourceText) =
getParseResultsForFile fileName fcsPos
// The syntax tree can be an intimidating set of types to work with.
// It is a tree structure but it consists out of many different types.
// See https://fsharp.github.io/fsharp-compiler-docs/reference/fsharp-compiler-syntax.html
// It can be useful to inspect a syntax tree via a code sample using https://fsprojects.github.io/fantomas-tools/#/ast
// For example `let a b c = ()` in
// https://fsprojects.github.io/fantomas-tools/#/ast?data=N4KABGBEAmCmBmBLAdrAzpAXFSAacUiaAYmolmPAIYA2as%%2BEkAxgPZwWQ2wAuYVYAEZhmYALxgAFAEo8BSLAAeAByrJoFHgCcArrBABfIA
// Let's say we want to find the (FCS) range for identifier `a` if the user's cursor is inside the function name.
// We will query the syntax tree to verify this is the case.
let maybeFunctionNameRange =
(fcsPos, parseAndCheckResults.GetParseResults.ParseTree)
||> ParsedInput.tryPick (fun _path node ->
match node with
// We know that `a` will be part of a `SynPat.LongIdent`
// This was visible in the online tool.
| SyntaxNode.SynPat(SynPat.LongIdent(longDotId = SynLongIdent(id = [ functionNameIdent ]))) when
// When our code fix operates on the user's code there is no way of knowing what will be inside the syntax tree.
// So we need to be careful and verify that the pattern is indeed matching the position of the cursor.
Range.rangeContainsPos functionNameIdent.idRange fcsPos
->
Some functionNameIdent.idRange
| _ -> None)
match maybeFunctionNameRange with
| None ->
// The cursor is not in a position we are interested in.
// This code fix should not trigger any suggestions so we return an empty list.
return []
| Some mBindingName ->
// It turns out we are inside a let binding and we have the range of the function name.
// Just for fun, we want to detect if there is a matching typed tree symbol present for the current name.
// We could have passed the function name from the syntax visitor, instead will we grab it from the source text.
let! functionName = sourceText.GetText mBindingName
// FSharpSymbolUse is reflecting the typed tree.
// See https://fsharp.github.io/fsharp-compiler-docs/fcs/symbols.html
let symbolUse: FSharp.Compiler.CodeAnalysis.FSharpSymbolUse option =
parseAndCheckResults.GetCheckResults.GetSymbolUseAtLocation(mBindingName.EndLine, mBindingName.EndColumn, line, [ functionName ])
let hasFunctionDefinitionSymbol =
match symbolUse with
| None -> false
| Some symbolUse ->
// We want to verify the found symbol is indeed a definition of a function
match symbolUse.Symbol with
| :? FSharpMemberOrFunctionOrValue -> true
| _ -> false
if not hasFunctionDefinitionSymbol then
return []
else
// Return a list of Fix records for when the code fix is applicable.
return [
{{
SourceDiagnostic = None
Title = title
File = codeActionParams.TextDocument
// Based on conditional logic, you typically want to suggest a text edit to the user.
Edits = [|
{{
// When dealing with FCS, we typically want to use the FCS flavour of range.
// However, to interact correctly with the LSP protocol, we need to return an LSP range.
Range = fcsRangeToLsp mBindingName
NewText = "Text replaced by %s{codeFixName}"
}}
|]
Kind = FixKind.Fix
}}
]
}}
"""
File.WriteAllText(path, removeReturnCarriage content)
Trace.tracefn $"Generated %s{Path.GetRelativePath(repositoryRoot, path)}"
let mkCodeFixSignature codeFixName =
let path =
repositoryRoot
</> "src"
</> "FsAutoComplete"
</> "CodeFixes"
</> $"{codeFixName}.fsi"
let content =
$"""module FsAutoComplete.CodeFix.%s{codeFixName}
open FsAutoComplete.CodeFix.Types
val title: string
val fix: getParseResultsForFile: GetParseResultsForFile -> CodeFix
"""
File.WriteAllText(path, removeReturnCarriage content)
Trace.tracefn $"Generated %s{Path.GetRelativePath(repositoryRoot, path)}"
let updateProjectFiles () =
let fsAutoCompleteProject =
repositoryRoot </> "src" </> "FsAutoComplete" </> "FsAutoComplete.fsproj"
File.SetLastWriteTime(fsAutoCompleteProject, DateTime.Now)
let fsAutoCompleteTestsLsp =
repositoryRoot
</> "test"
</> "FsAutoComplete.Tests.Lsp"
</> "FsAutoComplete.Tests.Lsp.fsproj"
File.SetLastWriteTime(fsAutoCompleteTestsLsp, DateTime.Now)
let (|IdentName|_|) (name: string) (identListNode: IdentListNode) =
match identListNode.Content with
| [ IdentifierOrDot.Ident stn ] when stn.Text = name -> Some()
| _ -> None
let getOakFor path =
let content = File.ReadAllText path
Fantomas.Core.CodeFormatter.ParseOakAsync(false, content)
|> Async.RunSynchronously
|> Array.head
|> fst
let appendItemToArrayOrList item path (node: ExprArrayOrListNode) =
let lastElement = node.Elements |> List.last |> Expr.Node
let startIndent = lastElement.Range.StartColumn
let lineIdx = lastElement.Range.EndLine - 1
let arrayEndsOnLastElement = node.Range.EndLine = lastElement.Range.EndLine
let updatedLines =
let lines = File.ReadAllLines path
let currentLastLine = lines.[lineIdx]
let spaces = String.replicate startIndent " "
if arrayEndsOnLastElement then
let endOfLastElement = currentLastLine.Substring(0, lastElement.Range.EndColumn)
let endOfArray = currentLastLine.Substring(lastElement.Range.EndColumn)
lines
|> Array.updateAt lineIdx $"{endOfLastElement}\n%s{spaces}%s{item}%s{endOfArray}"
else
lines |> Array.insertAt (lineIdx + 1) $"%s{spaces}%s{item}"
let content = String.concat "\n" updatedLines
File.WriteAllText(path, content)
Trace.tracefn $"Added \"%s{item}\" to %s{Path.GetRelativePath(repositoryRoot, path)}"
module List =
let exactlyOneOrFail (message: string) (items: 'T list) : 'T =
if items.Length = 1 then items.Head else failwith message
let pickOrFail (message: string) (chooser: 'T -> 'U option) (items: 'T list) : 'U =
match List.tryPick chooser items with
| None -> failwith message
| Some u -> u
let findArrayOrListOfFail (e: Expr) =
match e with
| Expr.ArrayOrList array -> array
| e -> failwithf $"Expected to find Expr.ArrayOrList, got %A{e}"
let findTypeWithNameOfFail (typeName: string) (mn: ModuleOrNamespaceNode) : ITypeDefn =
mn.Declarations
|> List.pickOrFail $"Expected to find ModuleDecl.TypeDefn for %s{typeName}" (function
| ModuleDecl.TypeDefn t ->
let tdn = TypeDefn.TypeDefnNode t
match tdn.TypeName.Identifier with
| IdentName typeName -> Some tdn
| _ -> None
| _ -> None)
let findArrayInAdaptiveFSharpLspServer () : ExprArrayOrListNode =
let oak = getOakFor AdaptiveServerStatePath
// namespace FsAutoComplete.Lsp
let ns =
oak.ModulesOrNamespaces
|> List.exactlyOneOrFail "Expected a single namespace in Oak."
// type AdaptiveState
let t = findTypeWithNameOfFail "AdaptiveState" ns
// let codefixes =
let codefixesValue =
t.Members
|> List.pickOrFail "Expected to find MemberDefn.LetBinding for codefixes" (function
| MemberDefn.LetBinding bindingList ->
match bindingList.Bindings with
| bindings ->
bindings
|> List.tryPick (fun binding ->
match binding.FunctionName with
| Choice1Of2(IdentName "codefixes") -> Some binding
| _ -> None)
| _ -> None)
let infixApp =
match codefixesValue.Expr with
| Expr.CompExprBody body ->
match List.last body.Statements with
| ComputationExpressionStatement.OtherStatement other ->
match other with
| Expr.InfixApp infixApp -> infixApp
| e -> failwithf $"Expected to find Expr.InfixApp, got %A{e}"
| ces -> failwithf $"Expected to find ComputationExpressionStatement.OtherStatement, got %A{ces}"
| e -> failwithf $"Expected to find Expr.CompExprBody, got %A{e}"
let appWithLambda =
match infixApp.RightHandSide with
| Expr.AppWithLambda appWithLambda -> appWithLambda
| e -> failwithf $"Expected to find Expr.AppWithLambda, got %A{e}"
let lambda =
match appWithLambda.Lambda with
| Choice1Of2 lambda -> lambda
| Choice2Of2 ml -> failwithf $"Expected to find ExprLambdaNode, got %A{ml}"
findArrayOrListOfFail lambda.Expr
let wireCodeFixInAdaptiveFSharpLspServer codeFixName =
try
let array = findArrayInAdaptiveFSharpLspServer ()
appendItemToArrayOrList $"%s{codeFixName}.fix tryGetParseAndCheckResultsForFile" AdaptiveServerStatePath array
with ex ->
Trace.traceException ex
Trace.traceError
$"Unable to find array of codefixes in %s{AdaptiveServerStatePath}.\nDid the code structure change?"
let mkCodeFixTests codeFixName =
let path =
repositoryRoot
</> "test"
</> "FsAutoComplete.Tests.Lsp"
</> "CodeFixTests"
</> $"%s{codeFixName}Tests.fs"
let contents =
$"module private FsAutoComplete.Tests.CodeFixTests.%s{codeFixName}Tests
open Expecto
open Helpers
open Utils.ServerTests
open Utils.CursorbasedTests
open FsAutoComplete.CodeFix
let tests state =
serverTestList (nameof %s{codeFixName}) state defaultConfigDto None (fun server ->
[ let selectCodeFix = CodeFix.withTitle %s{codeFixName}.title
ftestCaseAsync \"first unit test for %s{codeFixName}\"
<| CodeFix.check
server
\"let a$0 b c = ()\"
Diagnostics.acceptAll
selectCodeFix
\"let Text replaced by %s{codeFixName} b c = ()\"
])
"
File.WriteAllText(path, removeReturnCarriage contents)
Trace.tracefn $"Generated %s{Path.GetRelativePath(repositoryRoot, path)}"
let findListInTests () =
let oak = getOakFor TestsPath
// module FsAutoComplete.Tests.CodeFixTests.Tests
let testsModule =
oak.ModulesOrNamespaces
|> List.exactlyOneOrFail "Expected a single module in Oak."
// let tests state =
let testBinding =
testsModule.Declarations
|> List.pickOrFail "Expected to find ModuleDecl.TopLevelBinding for tests" (function
| ModuleDecl.TopLevelBinding binding ->
match binding.FunctionName with
| Choice1Of2(IdentName "tests") -> Some binding
| _ -> None
| _ -> None)
let appNode =
match testBinding.Expr with
| Expr.InfixApp infixApp ->
match infixApp.RightHandSide with
| Expr.App appNode -> appNode
| e -> failwithf $"Expected Expr.App, got %A{e}"
| e -> failwithf $"Expected Expr.InfixApp, got %A{e}"
findArrayOrListOfFail (List.last appNode.Arguments)
let wireCodeFixTests codeFixName =
try
let list = findListInTests ()
appendItemToArrayOrList $"%s{codeFixName}Tests.tests state" TestsPath list
with ex ->
Trace.traceException ex
Trace.traceError $"Unable to find array of tests in %s{TestsPath}.\nDid the code structure change?"
let scaffold (codeFixName: string) : unit =
// generate files in src/CodeFixes/
mkCodeFixImplementation codeFixName
mkCodeFixSignature codeFixName
// Wire up codefix to LSP servers
wireCodeFixInAdaptiveFSharpLspServer codeFixName
// Add test file
mkCodeFixTests codeFixName
// Wire up tests in test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs
wireCodeFixTests codeFixName
updateProjectFiles ()
Trace.tracefn $"Scaffolding %s{codeFixName} complete!"
let ensureScaffoldStillWorks () =
findArrayInAdaptiveFSharpLspServer () |> ignore
findListInTests () |> ignore
pipeline "EnsureRepoConfig" {
description "Configure custom git hooks, currently only used to ensure that code is formatted before pushing"
workingDir __SOURCE_DIRECTORY__
stage "Git" { run (fun _ -> Git.CommandHelper.gitCommand "" "config core.hooksPath .githooks") }
runIfOnlySpecified true
}
pipeline "ScaffoldCodeFix" {
description "Scaffold a new code fix."
workingDir __SOURCE_DIRECTORY__
stage "Scaffold" {
run (fun ctx ->
let codeFixName = ctx.GetAllCmdArgs() |> List.tryLast
match codeFixName with
| None -> printfn "Usage: dotnet fsi build.fsx -- -p ScaffoldCodeFix <name>"
| Some codeFixName -> ScaffoldCodeFix.scaffold codeFixName)
}
runIfOnlySpecified true
}
pipeline "EnsureCanScaffoldCodeFix" {
description "Ensure the ScaffoldCodeFix pipeline can still be executed."
workingDir __SOURCE_DIRECTORY__
stage "Ensure" { run (fun _ -> ScaffoldCodeFix.ensureScaffoldStillWorks ()) }
runIfOnlySpecified true
}
pipeline "Build" {
description "Default build pipeline"
workingDir __SOURCE_DIRECTORY__
stage "Build" {
run "dotnet tool restore"
run "dotnet build"
}
runIfOnlySpecified false
}
tryPrintPipelineCommandHelp ()